Make existing code c++17 compliant for future upgrade #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
Signed-off-by: The MathWorks, Inc. Roy.Lurie@mathworks.com
achristoforides
changed the title
jeffdiclemente
requested review from
carneyweb,
saschazelzer,
jeffdiclemente and
kevinleeMW
jeffdiclemente
approved these changes
Jun 26, 2020
kevinleeMW
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the project with -std=c++17, there are a few sections of the code which cause problems due to deprecation of certain APIs. This PR aims to fix these while still remaining the current c++ standard version (14) until a decision has been made to upgrade it.
In one instance, our code was using std::random_shuffle (which was deprecated), and in another, we were using std::binary_function (which was also deprecated). For the first issue, the usage of this API had to be updated; instead of using std::random_shuffle, we now use std;:shuffle and pass in the std::mt19937 as a UniformRandomBitGenerator. For the latter issue, switching this to use std::function<bool(ServiceListener, ServiceListener)> is sufficient.
All changes were built and tested on all platforms.