New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visitor should see smaller SECOND column on landing page with "Latest news" #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tab. Adds new component for LatestNews, which renders articles from API via props from ArticlesByCategory component. All tests passing
…iterates over them in order to extract the category colour and assign it to each segment in latest news column aaccordingly.
…est fixture file to test for correct sorting. Works as required
…in order - latest first. Adjusts implementation code.
…ry. Updates ArticleByCategory div id to differentiate between filteredf articles and LatestNews articles
…t to the right. All tests still passing
…y and LatestNews component. Not all test passingl, WIP
leiter007
changed the title
[WIP] Visitor should see smaller SECOND column on landing page with "Latest news"
Visitor should see smaller SECOND column on landing page with "Latest news"
Jun 5, 2019
oliverochman
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story
Changes proposed in this pull request:
What I have learned working on this feature:
Screenshot: