Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor should see smaller SECOND column on landing page with "Latest news" #23

Merged
merged 18 commits into from Jun 5, 2019

Conversation

leiter007
Copy link
Contributor

PT Story

Changes proposed in this pull request:

  • Integration test for viewing Latest News column on all category tabs, including landing page
  • Added component for LatestNews which fetches all articles - and sort them by `created_at´ (latest first)

What I have learned working on this feature:

  • Sorting on timestamp/date
  • Working with moment.js module
  • More about Cypress assertions

Screenshot:

Screenshot 2019-06-05 at 14 12 56

Screenshot 2019-06-05 at 14 12 48

Screenshot 2019-06-05 at 14 11 45

zanenkn and others added 17 commits June 4, 2019 15:21
…tab. Adds new component for LatestNews, which renders articles from API via props from ArticlesByCategory component. All tests passing
…iterates over them in order to extract the category colour and assign it to each segment in latest news column aaccordingly.
…est fixture file to test for correct sorting. Works as required
…in order - latest first. Adjusts implementation code.
…ry. Updates ArticleByCategory div id to differentiate between filteredf articles and LatestNews articles
…y and LatestNews component. Not all test passingl, WIP
@leiter007 leiter007 changed the title [WIP] Visitor should see smaller SECOND column on landing page with "Latest news" Visitor should see smaller SECOND column on landing page with "Latest news" Jun 5, 2019
Copy link
Contributor

@oliverochman oliverochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@oliverochman oliverochman merged commit ff7355a into CraftAcademy:development Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants