Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can save time #12

Merged
merged 25 commits into from Apr 4, 2019

Conversation

Projects
None yet
4 participants
@vick3d
Copy link
Collaborator

commented Apr 4, 2019

PT Story: User can save time

Description

As a User
In order to keep track of my working time
I would like to be able to save it

Changes proposed in this pull request:

  • Render a time tracking view
  • Add save button
  • Create post requests to API
  • Mock API testing
  • Add styling

What I have learned working on this feature:

Writing test in Cypress, Mock out API requests

Screenshots:

image

@perhegg

perhegg approved these changes Apr 4, 2019

@@ -0,0 +1,15 @@
describe('Display time tracking table', () => {

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
cy.visit('http://localhost:3000')
cy.get('div[name="timetracking"]')
.should('contain', 'Time Tracking')

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
@@ -0,0 +1,59 @@
describe('User can save time', () => {
it('User can save time', () => {

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson

const stub = cy.stub()
cy.on ('window:alert', stub)

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
import './commands'


This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
<Table.HeaderCell>Project</Table.HeaderCell>
<Table.HeaderCell>Task</Table.HeaderCell>
<Table.HeaderCell> </Table.HeaderCell>

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
@@ -0,0 +1,46 @@
import axios from 'axios'


This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@amandagibson
description: description,
fixedRate: fixedRate,
hourlyRate: hourlyRate
},{

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

maybe you cab go down one line and keep } on same level as {

This comment has been minimized.

Copy link
@amandagibson
src/App.js Outdated
Time Tracking
</Header>
<TimeTrackingTable
/>

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

put this on line 20

This comment has been minimized.

Copy link
@amandagibson
src/App.js Outdated
import LandingPage from './components/landingPage';
import Navbar from './components/navbar'
import Footer from './components/footer';

class App extends Component {

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 4, 2019

Collaborator

do we want this space?

This comment has been minimized.

Copy link
@amandagibson

@LauraRe LauraRe merged commit eb95c39 into CraftAcademy:development Apr 4, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.