Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can see saved times #16

Merged
merged 9 commits into from Apr 7, 2019

Conversation

Projects
None yet
4 participants
@LauraRe
Copy link
Collaborator

commented Apr 6, 2019

PT Story: User can see saved times

Description

As a User
In order to keep track of my progress
I would like to see my saved times

Changes proposed in this pull request:

  • get saved timesheets from api
  • use Stockholm timezone

What I have learned working on this feature:

  • how to mock api response in cypress
  • how you use the spread operator to add item as first object in an array
  • how to set a timezone with moment timezone package

Screenshots:

image

@LauraRe LauraRe marked this pull request as ready for review Apr 6, 2019

@amandagibson
Copy link
Member

left a comment

LGTM

@amandagibson

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Why isn't the customer number populating though?

@@ -30,13 +83,20 @@ export class TimeTrackingTable extends Component {
project: this.state.project,
activity: this.state.activity,
description: "description",
fixedRate: "0.0",
fixedRate: "",

This comment has been minimized.

Copy link
@vick3d

vick3d Apr 7, 2019

Collaborator

this change is messing up our unit tests and the build on semaphore.
So either switch back or fix the tests.

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 7, 2019

Author Collaborator

fixed.

@LauraRe

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 7, 2019

Why isn't the customer number populating though?

Because the timesheets api get response does not include it.

@vick3d

vick3d approved these changes Apr 7, 2019

@vick3d vick3d merged commit 5f4b282 into CraftAcademy:development Apr 7, 2019

1 check passed

semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.