Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should have a Dashboard #21

Merged
merged 6 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@amandagibson
Copy link
Member

commented Apr 9, 2019

PT Story:User should have a Dashboard

Description

As a User
In order to see all of my information in one place
I would like to have a Dashboard

Changes proposed in this pull request:

  • render dashboard
  • create navigation for logo

Screenshots:

Screenshot 2019-04-09 at 21 06 33
Screenshot 2019-04-09 at 21 06 22

@LauraRe

LauraRe approved these changes Apr 9, 2019

Copy link
Collaborator

left a comment

nice!

@@ -10,6 +10,8 @@ describe("User can fetch project activities data", () => {
.type("api_kitten")
.get("button")
.contains("Login")
.click()
.get('button[name="time_tracking"]')
.click();
});

This comment has been minimized.

Copy link
@perhegg

perhegg Apr 10, 2019

Collaborator

file name should be .feature for consistency.

This comment has been minimized.

Copy link
@amandagibson

amandagibson Apr 10, 2019

Author Member

you're right! fixed!

.get('h1[name="header"]')
.should('contain','My Dashboard')
})
})

This comment has been minimized.

Copy link
@perhegg

perhegg Apr 10, 2019

Collaborator

file name

This comment has been minimized.

Copy link
@amandagibson

amandagibson Apr 10, 2019

Author Member

changed!

@perhegg perhegg merged commit 1362361 into CraftAcademy:development Apr 10, 2019

3 of 6 checks passed

Header rules - khronos No header rules processed
Details
Pages changed - khronos All files already uploaded
Details
Redirect rules - khronos No redirect rules processed
Details
Mixed content - khronos No mixed content detected
Details
netlify/khronos/deploy-preview Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.