Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots to landing page #27

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@perhegg
Copy link
Collaborator

commented Apr 12, 2019

PT Story: Add screenshots to landing page

Description

Changes proposed in this pull request:

  • Replaces dummt screenshots with actual screenshots from the site

What I have learned working on this feature:

I have learnt how to modify further semantic ui elements

Screenshots:

Skärmklipp

@amandagibson

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

can you post a screenshot of the landing page?

@perhegg perhegg marked this pull request as ready for review Apr 12, 2019

@amandagibson
Copy link
Member

left a comment

:)

@LauraRe

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

I think the dashboard screenshot would look better in the middle, or the charts..I would leave the timesheets page on the right

import graphs from '../img/graphs.png'
import times from '../img/times.png'


This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 12, 2019

Collaborator

remove 2 spaces

This comment has been minimized.

Copy link
@perhegg

perhegg Apr 12, 2019

Author Collaborator

done

import graphs from '../img/graphs.png'
import times from '../img/times.png'



class LandingPage extends Component {

This comment has been minimized.

Copy link
@LauraRe

LauraRe Apr 12, 2019

Collaborator

remove space

This comment has been minimized.

Copy link
@perhegg

perhegg Apr 12, 2019

Author Collaborator

done

perhegg added some commits Apr 12, 2019

@vick3d

vick3d approved these changes Apr 12, 2019

@amandagibson amandagibson merged commit 9c2c42d into CraftAcademy:development Apr 12, 2019

3 of 6 checks passed

Header rules - khronos No header rules processed
Details
Pages changed - khronos 4 new files uploaded
Details
Redirect rules - khronos No redirect rules processed
Details
Mixed content - khronos No mixed content detected
Details
netlify/khronos/deploy-preview Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.