revert: back out #1500 to unblock TestFlight launch (P0)#1503
Merged
Conversation
This reverts commit d1ce303.
Test Results✅ All tests passed
Coverage
⏱️ Duration: 81.4s |
CraigBuckmaster
pushed a commit
that referenced
this pull request
Apr 17, 2026
Master is running ESLint with --max-warnings 0 and has accumulated 13 warnings across 9 files that block CI on every PR. Clearing them here so PR #1503 (the post-download launch-crash revert) can merge. - StreamingDot: lazy-initialize the Animated.Value via useState instead of reading useRef(...).current at render time (react-hooks/refs) - useAmicusThread: keep the standard fetch-on-mount, silence the react-hooks/set-state-in-effect rule with a scoped disable comment - import/order nits across MapErrorBoundary, TabNavigator, AmicusSettingsSection, and the four test files that interleaved jest.mock() calls with imports — consolidate imports first, then the jest.mock block (Jest hoists mocks regardless)
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestFlight build 1.0.5 (12) crashes on first launch immediately after the R2
scripture.dbdownload completes. Signature:Launch-to-crash delta ≈16 s, matching the R2 download window. Build (11) was fine. The only behavior-changing PR to land between (11) and (12) was #1500. Per Craig, #1501 was NOT in build (12).
Reverting #1500 restores the (11) bundle for the post-download launch path and unblocks (13).
What this PR does
This is a clean
git revertofd1ce303(the feature commit of #1500). It undoes exactly the 5 files the PR touched:app/src/components/amicus/AmicusPeekSheet.tsx— restored to pre-feat(ai-partner): continue-in-tab handoff from peek (#1464) #1500app/src/components/amicus/PeekMiniConversation.tsx— restored to pre-feat(ai-partner): continue-in-tab handoff from peek (#1464) #1500app/src/components/amicus/__tests__/AmicusPeekSheet.test.tsx— new tests removedapp/src/services/amicus/promotePeekToThread.ts— deletedapp/src/services/amicus/__tests__/promotePeekToThread.test.ts— deletedPR #1499 (map probe fix) is untouched. That PR only runs when the Map tab is navigated to, not on launch.
Why revert instead of targeted fix
A careful audit of the 5 files PR #1500 touched did not surface an obvious crash source on the boot path (no new migrations, no new providers, no new mount-time TurboModule calls). Per the brief, revert is preferred over a risky quick fix when the root cause is unclear — Craig needs the app to launch. Investigation writeup + re-land plan: see linked follow-up issue.
Verification plan
After merge, rebuild / resubmit:
Success criteria
scripture.dbdownload completeshttps://claude.ai/code/session_01NP991WRNgq8xhKAQtnm1rf