Remove wait associated with Experiment start summary #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #298 +/- ##
===========================================
+ Coverage 87.60% 87.64% +0.04%
===========================================
Files 58 58
Lines 3323 3319 -4
===========================================
- Hits 2911 2909 -2
+ Misses 412 410 -2
|
|
I thought we were planning to add a dry run mode as well that would let users see the path of execution before committing to a run? |
|
My understanding was that the |
billschereriii
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a 10 second pause if
summary=trueis provided toExperiment.start(). After receiving user feedback, we have decided to remove that pause (#294). A separate issue has been posted to enable a preview of the experiment launch summary without invokingExperiment.start().