Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehints2 #301

Closed
wants to merge 56 commits into from
Closed

Typehints2 #301

wants to merge 56 commits into from

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 6, 2023

Complete typehints for internal API

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #301 (d2f6770) into develop (5817084) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

❗ Current head d2f6770 differs from pull request most recent head 8c4bf47. Consider uploading reports for the commit 8c4bf47 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #301      +/-   ##
===========================================
- Coverage    87.78%   87.77%   -0.01%     
===========================================
  Files           58       59       +1     
  Lines         3323     3427     +104     
===========================================
+ Hits          2917     3008      +91     
- Misses         406      419      +13     
Impacted Files Coverage Δ
smartsim/_core/launcher/colocated.py 92.30% <71.42%> (-0.80%) ⬇️
smartsim/entity/entityList.py 92.85% <85.71%> (-7.15%) ⬇️
smartsim/settings/settings.py 76.47% <85.71%> (+10.84%) ⬆️
smartsim/database/orchestrator.py 83.33% <87.09%> (+0.12%) ⬆️
smartsim/_core/launcher/stepMapping.py 74.41% <87.50%> (+0.22%) ⬆️
smartsim/_core/launcher/taskManager.py 78.73% <88.23%> (-3.52%) ⬇️
smartsim/entity/dbnode.py 66.66% <88.23%> (+0.62%) ⬆️
smartsim/entity/model.py 96.39% <90.00%> (-0.75%) ⬇️
smartsim/_core/launcher/step/mpiStep.py 38.09% <91.66%> (+2.02%) ⬆️
smartsim/experiment.py 80.41% <95.00%> (-0.02%) ⬇️
... and 32 more

@ankona ankona closed this Jun 13, 2023
@ankona ankona deleted the typehints2 branch June 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant