Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal API typehints #303

Merged
merged 82 commits into from
Jun 22, 2023
Merged

Add internal API typehints #303

merged 82 commits into from
Jun 22, 2023

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jun 13, 2023

Add typehints to internal APIs

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #303 (fa9db5c) into develop (3f2dfa4) will decrease coverage by 0.31%.
The diff coverage is 90.70%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    87.85%   87.54%   -0.31%     
===========================================
  Files           59       59              
  Lines         3383     3461      +78     
===========================================
+ Hits          2972     3030      +58     
- Misses         411      431      +20     
Impacted Files Coverage Δ
smartsim/_core/utils/redis.py 87.75% <ø> (ø)
smartsim/_core/launcher/colocated.py 92.22% <40.00%> (-1.04%) ⬇️
smartsim/ml/torch/data.py 83.92% <52.94%> (-11.73%) ⬇️
smartsim/_core/launcher/taskManager.py 81.03% <71.42%> (-1.43%) ⬇️
smartsim/_core/launcher/util/shell.py 83.72% <75.00%> (ø)
smartsim/_core/launcher/step/mpiStep.py 40.90% <77.77%> (+2.81%) ⬆️
smartsim/_core/launcher/stepMapping.py 74.41% <81.25%> (-0.59%) ⬇️
smartsim/_core/control/manifest.py 92.23% <87.50%> (-2.60%) ⬇️
smartsim/_core/launcher/step/localStep.py 88.57% <87.50%> (-1.76%) ⬇️
smartsim/ml/tf/data.py 84.09% <88.88%> (-1.28%) ⬇️
... and 26 more

@ankona ankona marked this pull request as ready for review June 13, 2023 22:24
@MattToast MattToast self-requested a review June 22, 2023 17:03
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job -- LGTM!

@ankona ankona merged commit 0ddf7b3 into CrayLabs:develop Jun 22, 2023
10 checks passed
@ankona ankona deleted the typehints22 branch June 22, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants