Allow pinning of the co-located database #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellis13
previously requested changes
Jun 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #306 +/- ##
===========================================
+ Coverage 86.78% 87.12% +0.33%
===========================================
Files 59 59
Lines 3482 3518 +36
===========================================
+ Hits 3022 3065 +43
+ Misses 460 453 -7
|
MattToast
requested changes
Jun 26, 2023
- Refactor some of the tests to separate creation of experiment and db - Pin colocated database cpus based on the custom_pinning option instead of two different inputs
MattToast
requested changes
Jun 30, 2023
Throw in more tests for fun
MattToast
approved these changes
Jul 1, 2023
| "--loadmodule", | ||
| CONFIG.redisai | ||
| ] | ||
| ) |
ashao
dismissed
mellis13’s stale review
Questions were addressed offline and current implementation was carefully checked with Toast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the strategy for adding a co-located deployment for simulation and database. Prior, the co-located database was always pinned to the last N logical processors on a machine. In the case of a Slurm machine, user-specified bind settings were being overwritten leading to a general inflexibility for users trying to maximize performance. Additionally,
limit_app_cpuswas not working as intended because only the launcher command was being pinned and not the application launched by the launcher command.The changes here provide two options,
limit_db_cpusanddb_cpu_listto control the pinning of the co-located database.limit_db_cpusenables the pinning usingtasksetanddb_cpu_listis a user-provided string that specifies which processors the orchestrator should be bound to. Ifdb_cpu_listis not provided, the database is automatically pinned to the first N logical processors.