Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Japanese translations #20

Closed
Crease29 opened this issue Dec 9, 2021 · 2 comments · Fixed by #31
Closed

Missing Japanese translations #20

Crease29 opened this issue Dec 9, 2021 · 2 comments · Fixed by #31
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed translation This issue is about missing/wrong translations

Comments

@Crease29
Copy link
Owner

Crease29 commented Dec 9, 2021

PageLiner is missing Japanese translations. It would be really cool, if someone could provide these translations.

How do I add new translations?

  1. Fork this repository
  2. Create a new directory in _locales. Here you can find all supported language codes: https://developer.chrome.com/docs/webstore/i18n/#choosing-locales-to-support . Name your new directory by the language code.
  3. Copy the _locales/en/messages.json into your new folder.
  4. Translate all strings that are indexed by "message". You don't need to translate the strings that are indexed by "description", because these strings just describe where the message is shown or in which context it needs to be translated.
  5. Create a pull request 😊

Thank you very much for your help!

@Crease29 Crease29 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers translation This issue is about missing/wrong translations labels Dec 9, 2021
@MizuhoOkimoto
Copy link
Contributor

Hi @Crease29 , can I work on it? It would be great if you assign it to me! Thank you!

@Crease29
Copy link
Owner Author

Hi @MizuhoOkimoto, of course! Feel free 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed translation This issue is about missing/wrong translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants