Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Japanese translations #31

Merged
merged 3 commits into from Jan 5, 2022
Merged

Conversation

MizuhoOkimoto
Copy link
Contributor

@MizuhoOkimoto MizuhoOkimoto commented Dec 15, 2021

This fixes #20
I added ja file under _locales folder and Japanese translations for all strings that are indexed by "message".
If I need to improve, please let me know. If it's okay, I will add the new version to the Changelog.
Thank you so much 馃槂

@Crease29
Copy link
Owner

Hi @MizuhoOkimoto , thank you very much for your contribution! 馃
Could you please check your fork? I think there are missing some messages, that I've just added with commit e5d5d7c.
Would you be able to add them?

It would also be cool, if you add this on top of the changelog in the README.md in your pull request 馃槉

- **UPCOMING**
    - Added Japanese translations. Thanks to [@MizuhoOkimoto](https://github.com/MizuhoOkimoto)

Thanks a lot!

@Crease29
Copy link
Owner

@MizuhoOkimoto are you still working on this one? :)

@MizuhoOkimoto
Copy link
Contributor Author

Hi @Crease29 , I'm so sorry for being late! I fetched your changes and updated README.md as you mentioned above. I appreciate it if you can review them. Thank you so much and happy holidays!

@Crease29 Crease29 merged commit 307624d into Crease29:master Jan 5, 2022
@Crease29
Copy link
Owner

Crease29 commented Jan 5, 2022

All goo @MizuhoOkimoto , I'm also sorry for answering so late! Happy new year and thanks again for your contribution! That helps a lot :)

@MizuhoOkimoto
Copy link
Contributor Author

Thank you for reviewing, @Crease29 !
No, worries! Holidays are busy馃槃 Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Japanese translations
2 participants