Skip to content

Conversation

@TOPOFGR
Copy link
Contributor

@TOPOFGR TOPOFGR commented May 29, 2020

Details:

  • Internationalized error messages on utils

  • Refactor of firebaseError

@TOPOFGR TOPOFGR requested review from MateoKruk and tpiaggio May 29, 2020 22:01
@TOPOFGR TOPOFGR closed this May 29, 2020
@TOPOFGR TOPOFGR reopened this May 29, 2020
Copy link
Member

@tpiaggio tpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@MateoKruk MateoKruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 👨‍💻

@TOPOFGR TOPOFGR merged commit 59545a4 into master Jun 2, 2020
@TOPOFGR TOPOFGR deleted the feature/internationalize-error-messages branch June 2, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants