Sent open event #258
Sent open event #258
Conversation
email_mailbox/src/actions/threads.js
Outdated
| labelId | ||
| }); | ||
|
|
||
| export const updateStatusThread = (threadId, newStatus) => ({ |
There was a problem hiding this comment.
status instead of newStatus, check othres reducer, we send params with the same name that we will update it
electron_app/src/DBManager.js
Outdated
| if (date) params.date = date; | ||
| if (typeof unread === 'boolean') params.unread = unread; | ||
| if (typeof isMuted === 'boolean') params.isMuted = isMuted; | ||
| if (status) params.status = status; |
There was a problem hiding this comment.
remember when you added that function that stripped the falsy values from an object? Why not use that instead of modifying this function everytime you need to update a new field.
electron_app/src/clientManager.js
Outdated
| postOpenEvent(params) { | ||
| return client.postOpenEvent(params); | ||
| postOpenEvent(metadataKeys) { | ||
| return client.postOpenEvent({ metadataKeys }); |
There was a problem hiding this comment.
Does this actually work? I thought ClientAPI.postOpenEvent takes an array as input, not an object.
There was a problem hiding this comment.
that was updated in a new version of ClientAPI, first version takes an object
| } | ||
| case Thread.UPDATE_STATUS: { | ||
| const { status, threadId } = action; | ||
| if (!threadId || !status) { |
There was a problem hiding this comment.
why would these values be falsy? You should test this action.
| return thread(threadItem, action); | ||
| } | ||
| return thread; | ||
| return threadItem; |
There was a problem hiding this comment.
prefer iterate with singular name: thread and so, you will return thread
There was a problem hiding this comment.
thread is the function for a item in thread list.
4 participants
No description provided.