Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated the names to fit on the panel (take 2!) #268

Closed
wants to merge 3 commits into from

Conversation

impale1
Copy link
Contributor

@impale1 impale1 commented Apr 12, 2024

Take 2!
For other game modes!
namecomp
mvmname

@CriticalFlaw
Copy link
Owner

Any reason we can't just make the playername (and its surrounding panels) the same across all gamemodes?

Same question to changes in https://github.com/CriticalFlaw/TF2HUD.Fixes/blob/8f64918a3d08909c98e838b5f7357add057242d3/resource/ui/hudtournament.res#L147

@CriticalFlaw CriticalFlaw self-requested a review April 17, 2024 03:40
@impale1
Copy link
Contributor Author

impale1 commented Apr 23, 2024

hudtournament.res

I didn't remove if_competitive because their panels MUST be small to fit in the 4:3 aspect ratio.

spectatortournament.res

I won't remove if_mvm because the centered names look better.

@CriticalFlaw
Copy link
Owner

hudtournament.res

I didn't remove if_competitive because their panels MUST be small to fit in the 4:3 aspect ratio.

Why must ONLY competitive fit the 4:3 aspect ration? It brings back the point that the player panels should ideally be the same across all modes.

spectatortournament.res

I won't remove if_mvm because the centered names look better.

Again, doesn't make sense to have separate modes have different ways of displaying these panels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants