Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title File loading is out of sync with upstream file #63

Closed
afandian opened this issue Mar 4, 2019 · 0 comments
Closed

Title File loading is out of sync with upstream file #63

afandian opened this issue Mar 4, 2019 · 0 comments
Assignees
Labels
bug sprint-1 Sprint 1, 2019-03-04

Comments

@afandian
Copy link
Member

afandian commented Mar 4, 2019

The file available at http://ftp.crossref.org/titlelist/titleFile.csv has changed its headers. These are hard-coded to expect a certain ordering.

The format was most recently changed with [Jira CS-3961(https://jira.crossref.org/jira/browse/CS-3961) and updated in Cayenne master #349e12c452512c8f0906a5c816e7a9c599419b70 but this wasn't merged into the elastic-2019 branch.

To fix this, and prevent future brittleness, make column identification dynamic.

@afandian afandian added the bug label Mar 4, 2019
@afandian afandian added this to the elastic-search-migration milestone Mar 4, 2019
@afandian afandian self-assigned this Mar 4, 2019
@afandian afandian added the sprint-1 Sprint 1, 2019-03-04 label Mar 4, 2019
afandian added a commit that referenced this issue Mar 5, 2019
 - Look up fields based on their name, not order.
 - Unit tests for parsing and indexing.
 - Integration test for loading and indexing.
@afandian afandian closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sprint-1 Sprint 1, 2019-03-04
Projects
No open projects
Development

No branches or pull requests

1 participant