Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discard changes #484

Merged
merged 2 commits into from May 4, 2023
Merged

feat: discard changes #484

merged 2 commits into from May 4, 2023

Conversation

Candinya
Copy link
Member

@Candinya Candinya commented May 4, 2023

WHAT

🤖 Generated by Copilot at 28dfeba

Added a discard changes feature to the dashboard page editor, which lets users undo their modifications and delete their drafts. Modified the OptionsButton and PublishButton components to receive new props and display a discard button. Updated the editor.tsx page component to handle the discard logic and pass the props to the child components.

🤖 Generated by Copilot at 28dfeba

OptionsButton has
discard changes feature now
so does PublishButton

WHY

HOW

🤖 Generated by Copilot at 28dfeba

  • Add isModified and discardChanges props to OptionsButton and PublishButton components to enable discarding unsaved changes (link, link, link, link, link, link, link)
  • Define discardChanges function in Editor page component to delete draft from local storage and navigate back to previous page (link)
  • Pass isModified prop to OptionsButton and PublishButton components based on visibility state variable in Editor page component (link, link)

CLAIM REWARDS

For first-time contributors, please leave your xLog address and Discord ID below to claim your rewards.

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xlog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 3:37pm

@Candinya Candinya marked this pull request as ready for review May 4, 2023 04:08
@github-actions
Copy link

github-actions bot commented May 4, 2023

📦 Next.js Bundle Analysis for xlog

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 693.46 KB (🟡 +226 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/dashboard/[subdomain]/editor 2.6 MB 3.28 MB 959.19% (🟡 +0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@github-actions
Copy link

github-actions bot commented May 4, 2023

📦 Next.js Bundle Analysis for xlog

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 693.49 KB (🟡 +226 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/dashboard/[subdomain]/editor 2.6 MB 3.28 MB 959.22% (🟡 +0.04%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@DIYgod DIYgod merged commit 9daf35a into dev May 4, 2023
3 checks passed
@DIYgod DIYgod deleted the feat/discard-changes branch May 4, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants