Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version tracking issues #38

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Version tracking issues #38

merged 3 commits into from
Sep 1, 2022

Conversation

mtkraai
Copy link
Contributor

@mtkraai mtkraai commented Aug 31, 2022

Since version 0.1.0, this module has downloaded the rpm file with every Puppet run, and starting with 0.3.0, the package resource causes errors from yum.

This PR is two changes that seem to fix these two issues.

@ffalor
Copy link
Contributor

ffalor commented Aug 31, 2022 •
edited
Loading

@mtkraai thank you very much for catching the issue and contributing back.

QQ the changes to lib/puppet/provider/sensor_download/sensor_download.rb are they just to help debug or were you seeing a issue with that code? I reread your PR I see what you are saying now.

@ffalor ffalor added bug Something isn't working ok-to-test Run PR Acceptance tests labels Aug 31, 2022
@mtkraai
Copy link
Contributor Author

mtkraai commented Aug 31, 2022

Feel free to remove the extra Puppet.debug lines and change the fact lookup back to a single line. The issue was that the hash key is a symbol (:version), not a string ('version').

@ffalor ffalor merged commit 1a6c1fd into CrowdStrike:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ok-to-test Run PR Acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtkraai @ffalor @mkraai-cpts