Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add proxy support #41

Merged
merged 3 commits into from
Sep 22, 2022
Merged

add proxy support #41

merged 3 commits into from
Sep 22, 2022

Conversation

ffalor
Copy link
Contributor

@ffalor ffalor commented Sep 20, 2022

This pr adds proxy support for windows and linux. Closes #40

new module params:

  • proxy_host
  • proxy_port
  • proxy_enabled

limitations:

  • There is no way to configure Proxy settings on Mac instead falcon uses the OS
  • For windows proxy settings are only set at install time, and will not be updated/changed after install time due to the fact windows doesn't have falconctl

@ffalor ffalor added enhancement New feature or request ok-to-test Run PR Acceptance tests labels Sep 20, 2022
@ffalor
Copy link
Contributor Author

ffalor commented Sep 21, 2022

The two CI failures are on Ubuntu 2016 - it is failing the puppet agent install (not due to the module code).

2020 and 2022 are green

@CossyCosmas
Copy link

Thanks for implementing this functionality so quickly.

@ffalor ffalor merged commit ca7b07f into main Sep 22, 2022
@ffalor ffalor deleted the proxy branch September 22, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmmatos carlosmmatos carlosmmatos approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ok-to-test Run PR Acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy Host & Port Support?
3 participants
@ffalor @CossyCosmas @carlosmmatos