Accept Sensitive for CID #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pull the Value for CID from our Secret-Vault, as we consider CID as worthy of Protection. Our Secret-Vault yields Sensitive[String]. In my Opinion Writers of Profile-Modules should not be bothered with handling Values of Type Sensitive. Passing them over to the Component-Modules, (like “falcon”) should “just work”. - let init.pp accept CID of Datatype Sensitive[String] - do the Unwrap at the latest possible Location
|
@cocker-cc sorry for the delay - I will review this soon. Thanks for your patience and contribution! |
ffalor
added
ok-to-test
ffalor
approved these changes
Aug 30, 2023
|
@cocker-cc thanks for your PR v0.8.0 has been released with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pull the Value for CID from our Secret-Vault, as we consider CID as worthy of Protection. Our Secret-Vault yields Sensitive[String]. In my Opinion Writers of Profile-Modules should not be bothered with handling Values of Type Sensitive. Passing them over to the Component-Modules, (like “falcon”) should “just work”.