-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work in Nightly #99
Comments
It also doesn't work on macOS 10.12.4. |
Windows seems still to work. "Only" Linux and macOS broke. |
Correction: v0.8.3.1 is indeed broken on all platforms. The current dev version is working, however. |
I'm likely not going to solve this for now. Nightly is not a high priority and my time is very fragmented over several projects. The current dev/master version works as expected and will become the stable release before FF55 goes stable. |
I (and a bunch of other people) have used TabCenter for vertical tabs, but it will not be supported at all in Fx >55 (latest nightly is already 56). |
@ojab I understand this. v0.8.4 will support FF55+, this version will get released shortly before FF55 gets released. If it is helpful I can provide the current developer version (which is the version in the master branch) as a .xpi file here in a few hours. Alternatively, you can create the xpi file by yourself by using the jpm tool. |
It will be really awesome if you could push it to the beta channel on AMO, so it will be signed & anyone be able to install it without changing Fx security settings. |
@ojab There's actually a WebExtensions replacement for TC here: https://github.com/eoger/tabcenter-redux |
I will likely create a beta channel at some point, but not in the foreseeable future, since I need to manually maintain it permanently then. For now, here is the alpha version which works in Nightly: vertical-tabs-reloaded-0.8.4-alpha.zip @Keith94 It's completely okay for me if you use another vertical tab solution or several at the same time or switch back and forth. Even more when the other solutions are open source as well. However, it isn't really nice if you report bugs for project A and then advertise project B in these bug reports. And that is generally true, no matter if it is about my project or another. |
If somebody was quick and already tried the .zip file before: please retry :) |
I actually reconsidered. There you go https://addons.mozilla.org/firefox/addon/vertical-tabs-reloaded/versions/beta // @ojab |
Seems to work great on the Nightly version. The only issue I came across so far is that tabs remain visible in fullscreen, or when viewing YouTube videos in fullscreen, regardless of the option "Hide tabs in fullscreen" being enabled or disabled. (Windows 10 x64, Firefox 55.0b2 64-bit) Thanks for all the hard work! 👍 |
@Keith94 as far as I know, Tabcenter Redux still requires you to hide the default tab bar with another addon. Has it changed? |
@leedoyle Can't be done yet on Firefox's side: https://bugzilla.mozilla.org/show_bug.cgi?id=1332447 |
@Keith94 I know it's not feasible w/ WE yet, but Vertical Tabs Reloaded does that as it's a hybrid extension. And more importantly, the original Tab Center has been doing that, too. |
@Croydon , thanks for the dev release. Is the problem of not being able to drag-and-drop tabs known to be an issue with this version and Firefox 54? |
@asampal The dev version only supports FF55+ official. Also it depends which sidebar you are using, the WebExtensions sidebar has no drag&drop implementation yet, but I'm guessing you are using the legacy one and there it should work. What other add-ons are you using? |
@Croydon , I'm also using Tab Mix Plus - the other add-ons aren't tab related, so I don't think they should cause problems. As you point out, on Nightly, drag-and-drop works correctly with 0.8.4-alpha, but that version of Firefox has some glitches every now and then which make me prefer v54 at the moment. |
I'm not sure what caused the drag-and-drop problem, but after a restart of browser (which I had done before), this now works with VTR 0.8.4-alpha and FF 54. |
0.8.4-alpha with Firefox 55.0b9 (32-bit) on KubuntuTested:
✅
+1 0.8.4-alpha or greater with Firefox 54.0.1 (64-bit) on KDE Plasma 5 on FreeBSD-CURRENTI'll test later. (I tested release 0.8.3.1 earlier. No problem with full screen.) |
RapidRelease/Calendar - MozillaWiki – with 55 scheduled for release Tuesday 2017-08-08 (three days from now), might it be sensible to make 0.8.4 available as an update on Monday? 0.8.4-alpha with Firefox 54.0.1 (64-bit) on KDE Plasma 5 on FreeBSD-CURRENTTested over a three-week period. Drag-and-drop across windows, across multiple desktops, is OK.
+1 |
@grahamperrin This was the original plan all the way, have a look at the very beginning of #13 for a timetable :) |
My bad! #99 (comment) makes it clear. Thanks. |
v0.8.4 is now in the review queue. I will close this issue, when the version is public. |
Published. |
Add-on version: 0.8.3.1
Firefox version: 55.0a1
OS + OS-Version: Windows 8
Other tab + user interface related add-ons: N/A
Installing the add-on in a clean profile doesn't seem to work. Horizontal tabs are still visible and the vertical tabs don't appear. Browser Console:
The text was updated successfully, but these errors were encountered: