Fix required argument check for upgrade actions.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `upgrade status` and `upgrade cancel` the `--cluster` argument is required. However, it wasn't being checked and as a result, the error that wasn't indicative of what really was wrong. So, we just add the necessary validation step to the actions.
abrightwell
force-pushed
the
abrightwell/upgrade-fix
branch
from
97e4224
to
31a103f
Compare
will
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
upgrade statusandupgrade cancelthe--clusterargument isrequired. However, it wasn't being checked and as a result, the error
that wasn't indicative of what really was wrong. So, we just add the
necessary validation step to the actions.