Skip to content
This repository has been archived by the owner. It is now read-only.

iOS10 Support? #48

Closed
briananderson1222 opened this issue Aug 24, 2016 · 21 comments
Closed

iOS10 Support? #48

briananderson1222 opened this issue Aug 24, 2016 · 21 comments

Comments

@briananderson1222
Copy link

@briananderson1222 briananderson1222 commented Aug 24, 2016

Curious if anyone has looked into iOS 10 support for this plugin.

I tested this out for the first time today and I am seeing this error when calling cordovaSecureStorage.set

message: "Failure in SecureStorage.set() - errSecDefault"

I will continue looking into this to see if I can find more information and will pass along any findings

EDIT: This seems to affect all setting and fetching

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Aug 24, 2016

Apparently going into Compatibility Settings and enabling Keychain Sharing 'fixes' the issue. Haven't been doing iOS specific development for a while now so hoping that bringing this up might shed some light..

EDIT: From talking to some iOS Dev friends apparently there haven't really even been much in the way of changes when it comes to the keychain for iOS10. It looks like the SAMKeychain plugin is being used under the hood so it's possible the error is stemming from something in that plugin

EDIT2: So it looks like this plugin is using a year old version of this plugin.. maybe that has something to do with the lack of iOS10 support.. Going to see what happens if I pull in more up to date files from that plugin

EDIT3: That's a no go on pulling in the latest from that plugin. Would love to get some eyes on this since the iOS10 release is coming up soon @ggozad

@ggozad
Copy link
Member

@ggozad ggozad commented Aug 25, 2016

Hey @briananderson1222!
I haven't had a chance to look into this. I would really appreciate it if you do continue... Would you be able to make a branch updating the plugin so that I can have a look as well?

@ggozad
Copy link
Member

@ggozad ggozad commented Aug 25, 2016

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Aug 25, 2016

@ggozad Is there a reason the SAMKeychain code is so out of date? Also, is there a reason that 'SAM' is renamed to 'SS' or was this what the library used a year ago when this code was last updated?

@ggozad
Copy link
Member

@ggozad ggozad commented Aug 25, 2016

@briananderson1222 indeed SSKeychain apparently became SAMKeychain. There's no particular reason, SSKeychain was more or less a sane simple API around keychain which is why it was used.

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Aug 25, 2016

@ggozad Okay thanks for the background information. I'll continue looking into this as time allows and open a PR if I can get it working. Let me know if there is any other background information that may be useful

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Aug 25, 2016

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Aug 25, 2016

I've made the upgrade to the latest version if you would like me to put up a PR for that.. unfortunately doesn't seem to fix the underlying Keychain issue on iOS10

@ggozad
Copy link
Member

@ggozad ggozad commented Sep 13, 2016

Doomsday has come and gone. All seems fine here, did you encounter any trouble?

@ggozad
Copy link
Member

@ggozad ggozad commented Sep 14, 2016

@briananderson1222 closing this as everything seems fine on iOS 10. If you do encounter any problems let me know and will reopen.

@ggozad ggozad closed this Sep 14, 2016
@fmhun
Copy link

@fmhun fmhun commented Sep 15, 2016

Hi @ggozad, @briananderson1222

I still encountering a similar issue on iphone 7 simulator (iOS 10), with Xcode version 8.0 (8A218a) and lastest plugin version from git master branch.

The ss.set() method returns the following error :

message: "Failure in SecureStorage.set() - Refer to SecBase.h for description"

Are you experiencing the same issue ?

@ggozad ggozad reopened this Sep 15, 2016
@ggozad
Copy link
Member

@ggozad ggozad commented Sep 15, 2016

Hey @fmhun /cc @briananderson1222
I am not sure what to take from this.
Tests all pass just fine on a real device, at least on my iphone 6 running ios 10.
Tests fail on emulator both on iphone 7 and 6.

We deployed the latest release successfully on our own app and have had no problems reported so far.
This indicates that the problem is with the emulators, but of course I would like to resolve it altogether.

Would appreciate verification of tests passing on different physical devices.

@briananderson1222
Copy link
Author

@briananderson1222 briananderson1222 commented Sep 15, 2016

My experience has been the same as @ggozad. If you do want it to work on a simulator I have had luck with enabling the 'Keychain Accessbility' Capability as mentioned in this issue: https://openradar.appspot.com/27844971. I would monitor this issue as it appears to be an issue that stems from the the simulator itself.

@ggozad
Copy link
Member

@ggozad ggozad commented Sep 15, 2016

Will leave this open even if it does not affect apps in production. If something changes please report here to keep everybody in the loop.

@ggozad ggozad closed this Oct 11, 2016
@azhang66
Copy link
Contributor

@azhang66 azhang66 commented Oct 11, 2016

Has a resolution been reached on this issue?

@ggozad
Copy link
Member

@ggozad ggozad commented Oct 11, 2016

Well everybody reported the problem only appears on the emulator and seems to be a known bug. Is this different for you?

@ggozad ggozad reopened this Oct 11, 2016
@azhang66
Copy link
Contributor

@azhang66 azhang66 commented Oct 11, 2016

Well, kinda. I think we should leave this open for discussion in case a solution is found.

@wh33ler
Copy link

@wh33ler wh33ler commented Dec 20, 2016

I get this error also on a device. But not directly. After a fresh install and live building on the device at some point this issue appears and from then on it doesn't work anymore. Any news on this?

@ggozad
Copy link
Member

@ggozad ggozad commented Dec 22, 2016

Hey @wh33ler , sorry for the late reply, christmas and all :)
We haven't experienced this on devices yet. Could you please run the test and report the errors you get on the console, on a real device?

@jvjvjv
Copy link
Contributor

@jvjvjv jvjvjv commented Feb 16, 2017

I actually haven't been receiving errors with this under 10.2 and 10.2.1

@ggozad
Copy link
Member

@ggozad ggozad commented Feb 17, 2017

@jvjvjv yep this is indeed the case, had forgotten to come back to this.

@ggozad ggozad closed this Feb 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants