Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X509CRLBuilder and NextPublish extension #23

Closed
jalliot opened this issue Jun 14, 2018 · 4 comments
Closed

X509CRLBuilder and NextPublish extension #23

jalliot opened this issue Jun 14, 2018 · 4 comments

Comments

@jalliot
Copy link

jalliot commented Jun 14, 2018

I know CRL extensions modification is on your todo list but there is at least one beside CRLNumber that should be implemented in priority: NextPublish extension.
At the moment, even if we change ThisUpdate and NextUpdate, the original NextPublish extension is not modified or even settable.

I intended to use this new class to generate CRLs in the future but lack of support of the NextPublish means that those generated CRLs would have dates set in the past.
From an API perspective, just add a new NextPublish public property like for ThisUpdate and NextUpdate. If not set AND ThisUpdate/NextUpdate differ from the original CRL, I guess the best would be to remove entirely the extension if it is present.

@Crypt32
Copy link
Collaborator

Crypt32 commented Jun 14, 2018

I will take this into consideration. I think the idea with additional property is good enough. But the behavior should be: NULL by default. Do not copy this extension from source CRL and leave it up to API consumer to provide this extension. One more thing: should I validate NextPublish (when presented) whether it is within This and Next update?

@jalliot
Copy link
Author

jalliot commented Jun 15, 2018 via email

Crypt32 added a commit that referenced this issue Oct 22, 2018
@Crypt32
Copy link
Collaborator

Crypt32 commented Oct 22, 2018

Fixed in v3.4.1

@Crypt32 Crypt32 closed this as completed Oct 22, 2018
@Crypt32
Copy link
Collaborator

Crypt32 commented Oct 24, 2018

Please, let me know if this works for you as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants