Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options for Base Currency and Quote Currency #314

Merged
2 commits merged into from Jun 8, 2018

Conversation

Projects
None yet
1 participant
@december-soul
Copy link
Contributor

december-soul commented Jun 6, 2018

With this changes it is possible to use a template like this:
template: "[{{analysis.config.candle_period}} / {{analysis.config.period_count}}] {{market}} {{indicator}} is {{status}}! ({{values}}) {{ '\n' -}}https://www.tradingview.com/symbols/{{market_from}}{{market_to}}/technicals/ {{ '\n' -}}https://bittrex.com/Market/Index?MarketName={{market_to}}-{{market_from}}{{ '\n' -}}{{ '\n' -}}"

This will create

[1h / 10] DASH/BTC momentum is cold! ({'momentum': '-0.00002000'})

https://www.tradingview.com/symbols/DASHBTC/technicals/

https://bittrex.com/Market/Index?MarketName=BTC-DASH

only to better assemble the URLs
I like to be able to click the URLs directly

@ghost

This comment has been minimized.

Copy link

ghost commented Jun 6, 2018

I like this change, however I feel like we should use base_currency and quote_currency as the template parameter names (because that's what they are).

Also doing the split twice adds even more computational inefficiency to code execution that is already quite slow... something like base, quote = market.split('/') would be nicer.

@ghost

This comment has been minimized.

Copy link

ghost commented Jun 8, 2018

LGTM 👍

@ghost ghost merged commit 7ea9255 into CryptoSignal:master Jun 8, 2018

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.