570 - fix for the endorsing/baking rights #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkosecki
requested review from
dorians,
vishakh,
ivanopagano,
ba205,
anonymoussprocket and
bhaskarkishore
| @@ -531,14 +531,15 @@ object TezosTypes { | |||
| level: Int, | |||
| delegate: String, | |||
| priority: Int, | |||
| estimated_time: java.sql.Timestamp | |||
| estimated_time: ZonedDateTime | |||
There was a problem hiding this comment.
Curious, Why have we moved away from simple timestamps?
There was a problem hiding this comment.
I've suggested this to keep the domain model clean of things related to a database.
This helps immediately to decode json datetimes with no custom decoding definitions, and allows (if ever needed) more handle to operate on the datetime values.
vishakh
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #570
Changed way of fetching endorsing rights. Now they are being batched.