New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log macro for pointer output and remove duplicate code #1547

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@RadWolfie
Copy link
Member

RadWolfie commented Feb 6, 2019

Title says it all.

Before: 0x0000000x0AFEF598 -> DSBUFFERDESC* {
After: 0x0AFEF598 -> DSBUFFERDESC* {

Plus this PR need to be merge before I can create new commits to include log macro verbose for xbox's DSound and host's DirectSound.

RadWolfie added some commits Feb 5, 2019

Fixed macro bug for pointer
Before: 0x0000000x0AFEF598

Now: 0x0AFEF598
Remove duplicate code
ENUM2STR_CASE_DEF is exactly the same as ENUM2STR_CASE

Since ENUM2STR_CASE is being used as primary, no longer need a reason to have duplicate maco method.

@LukeUsher LukeUsher merged commit d9fcc83 into Cxbx-Reloaded:develop Feb 6, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@RadWolfie RadWolfie deleted the RadWolfie:fix-log-macro branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment