Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
DirectSound unfocus audible option + minor fixes #1586
Following changes in this pull request:
EDIT: By default, audio will still remain muted while unfocus. Unless changed in the audio's settings dialog.
Apr 13, 2019
1 check passed
Just a note. You might want to change the phrase to "Disable mute when window is unfocused" or "Disable mute on/during absence" (or "Disable mute while absent/away from window"). It's because that shortened ending "... on unfocus" can be confusing to many users. I wouldn't have been sure of what it was for if I hadn't read your post above.
Unfocus is a well-known term, absent/absence/away are less clear IMHO.
But to piggy-pack on this remark: This menu option could be inverted in meaning and be called "Mute when unfocused" (default on), which is much shorter, and (because like this it no longer is a double negative, and less words are used), probably much better to understand.