Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectSound unfocus audible option + minor fixes #1586

Merged
merged 4 commits into from Apr 13, 2019

Conversation

Projects
None yet
5 participants
@RadWolfie
Copy link
Member

RadWolfie commented Apr 12, 2019

Following changes in this pull request:

  • Add disable mute on unfocus. (tick it to able hear gameplay while Cxbx-Reloaded is not active window)
  • Rename "Enable Hardware Video Mode" to "Enable Exclusive Fullscreen Mode".
  • Repaired generator resource files.

image

EDIT: By default, audio will still remain muted while unfocus. Unless changed in the audio's settings dialog.

@RadWolfie

This comment has been minimized.

Copy link
Member Author

RadWolfie commented Apr 13, 2019

"Disable mute on unfocus" option is normally for front-end third-party and possibility some broadcast tools didn't receive audio from the emulation.

@AzurikRiseOfPerathia

This comment has been minimized.

Copy link

AzurikRiseOfPerathia commented Apr 13, 2019

Why not make a volume bar 0% to 100% to adjust the audio?

@RadWolfie

This comment has been minimized.

Copy link
Member Author

RadWolfie commented Apr 13, 2019

Not relative to this pull request. If a flag DSBCAPS_GLOBALFOCUS is not included, then you cannot hear the audio outside of the emulation.

EDIT: Volume bar may will be feature in the new GUI.

@LukeUsher LukeUsher merged commit 670d906 into Cxbx-Reloaded:develop Apr 13, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@RadWolfie RadWolfie deleted the RadWolfie:ds-globalfocus-option branch Apr 13, 2019

@ObiKKa

This comment has been minimized.

Copy link

ObiKKa commented Apr 16, 2019

Just a note. You might want to change the phrase to "Disable mute when window is unfocused" or "Disable mute on/during absence" (or "Disable mute while absent/away from window"). It's because that shortened ending "... on unfocus" can be confusing to many users. I wouldn't have been sure of what it was for if I hadn't read your post above.

@PatrickvL

This comment has been minimized.

Copy link
Member

PatrickvL commented Apr 16, 2019

Unfocus is a well-known term, absent/absence/away are less clear IMHO.

But to piggy-pack on this remark: This menu option could be inverted in meaning and be called "Mute when unfocused" (default on), which is much shorter, and (because like this it no longer is a double negative, and less words are used), probably much better to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.