Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Cxbx-R to compile (without debugger) if a C# compiler isn't found #1613

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@LukeUsher
Copy link
Member

commented May 16, 2019

Also fixed an incorrect comment while I was at it.

@LukeUsher

This comment has been minimized.

Copy link
Member Author

commented May 16, 2019

Going to be tweaking this until AppVeyor no longer fails, after that, it should be good to merge

@@ -1,10 +1,5 @@
cmake_minimum_required (VERSION 3.8)

# Enforce to use Windows 8.1 SDK
if(${CMAKE_HOST_SYSTEM_NAME} STREQUAL "Windows")

This comment has been minimized.

Copy link
@LukeUsher

LukeUsher May 16, 2019

Author Member

This has been removed because we don't actually require 8.1, was just used that as a default to support MSVC2015 and MSVC2017, but now cmake can take care of this

@PatrickvL PatrickvL merged commit 350a5ca into Cxbx-Reloaded:develop May 16, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

RadWolfie added a commit to RadWolfie/Cxbx-Reloaded that referenced this pull request May 16, 2019

fix the code style from previous pull request Cxbx-Reloaded#1613
Plus make github happy with end of file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.