Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSound's Multi-thread Issue #1654

Merged
merged 2 commits into from Jul 10, 2019

Conversation

Projects
None yet
2 participants
@RadWolfie
Copy link
Member

commented Jul 9, 2019

The changes contain three things, relocate the lock to inside the patch function as the first thing it get used. And replaced Windows' critical section function to std::mutex method. Plus a minor fix of the warning message in compiler.

With these changes, Soldier of Fortune II no longer crash on boot often or the need to slow down the emulation process.

I have tested at least 6 titles to ensure regression had not occurred.

@RadWolfie

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

Also, I had performed a manual regex replacement than manual insertion work to be sure everything is placed where it's needed or not.

@LukeUsher LukeUsher merged commit d6e6e4a into Cxbx-Reloaded:develop Jul 10, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@RadWolfie RadWolfie deleted the RadWolfie:fix-multithread-issue branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.