Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xapi controller capabilities structure #1708

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@aav7fl
Copy link
Contributor

commented Aug 28, 2019

There's a bug with the Xapi controller capabilities structure which places it in the wrong memory address. This fixes it.

Resolves controller input issues in: Cxbx-Reloaded/game-compatibility#666

@LukeUsher

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Excellent work, great find

@PatrickvL PatrickvL merged commit b590dd6 into Cxbx-Reloaded:develop Aug 28, 2019

3 checks passed

Cxbx-Reloaded.Cxbx-Reloaded Build #20190828.3 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aav7fl aav7fl deleted the aav7fl:4C410001-Star-Wars-Obi-Wan branch Aug 28, 2019

@x1nixmzeng

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

The same fix was needed to fix controller vibration, It may be worth sanity checking other xinput structs for packing

@ObiKKa

This comment has been minimized.

Copy link

commented Sep 1, 2019

Ooh, '666', a symbolic number for the Mark for the Beast; and also rather similar to the Order 66 sub plot in Star Wars Episode 3 movie. "Ironic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.