Fix Xapi controller capabilities structure #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work, great find |
|
The same fix was needed to fix controller vibration, It may be worth sanity checking other xinput structs for packing |
|
Ooh, '666', a symbolic number for the Mark for the Beast; and also rather similar to the Order 66 sub plot in Star Wars Episode 3 movie. "Ironic". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug with the Xapi controller capabilities structure which places it in the wrong memory address. This fixes it.
Resolves controller input issues in: Cxbx-Reloaded/game-compatibility#666