Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xapi controller capabilities structure #1708

Merged
merged 1 commit into from Aug 28, 2019
Merged

Fix Xapi controller capabilities structure #1708

merged 1 commit into from Aug 28, 2019

Conversation

@aav7fl
Copy link
Contributor

@aav7fl aav7fl commented Aug 28, 2019

There's a bug with the Xapi controller capabilities structure which places it in the wrong memory address. This fixes it.

Resolves controller input issues in: Cxbx-Reloaded/game-compatibility#666

@LukeUsher
Copy link
Member

@LukeUsher LukeUsher commented Aug 28, 2019

Excellent work, great find

Loading

@PatrickvL PatrickvL merged commit b590dd6 into Cxbx-Reloaded:develop Aug 28, 2019
3 checks passed
Loading
@aav7fl aav7fl deleted the 4C410001-Star-Wars-Obi-Wan branch Aug 28, 2019
@x1nixmzeng
Copy link
Contributor

@x1nixmzeng x1nixmzeng commented Sep 1, 2019

The same fix was needed to fix controller vibration, It may be worth sanity checking other xinput structs for packing

Loading

@ObiKKa
Copy link

@ObiKKa ObiKKa commented Sep 1, 2019

Ooh, '666', a symbolic number for the Mark for the Beast; and also rather similar to the Order 66 sub plot in Star Wars Episode 3 movie. "Ironic".

Loading

@gamecare
Copy link

@gamecare gamecare commented Jan 23, 2020

Has anyone found out the issue with the missing/invisible TEXT ?
So far its running perfect (apart from the missing text that is)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants