Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize pCurrentvertexShaderStreamInfo to nullptr #1723

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@NZJenkins
Copy link
Contributor

commented Sep 11, 2019

There's a branch that checks if this is nullptr, but it might not be unless we initialize it
Fixes Lego Star Wars II

@PatrickvL PatrickvL merged commit ea17cb6 into Cxbx-Reloaded:develop Sep 11, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Cxbx-Reloaded.Cxbx-Reloaded Build #20190911.1 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@NZJenkins NZJenkins deleted the NZJenkins:lsw2_fix branch Sep 11, 2019

@LukeUsher

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Nice spot, all pointers that are unset should be initialized to nullptr/xbnullptr/similar to allow them to be detected/checked for validity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.