Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Audio Frequency #1815

Merged

Conversation

@RadWolfie
Copy link
Member

RadWolfie commented Jan 10, 2020

Some titles with audio speed up such as

  • GTA 3 (confirmed)
  • GTA Vice City (confirmed)
  • MechAssault (confirmed)
  • Dragon's Lair (no change)
  • Half-Life 2 (confirmed by @Margen67)
  • Hobbit (confirmed by @medievil1)

should be resolved by this pull request.

@Margen67

This comment has been minimized.

Copy link
Contributor

Margen67 commented Jan 10, 2020

Improves sound in Half-Life 2.

@gandalfthewhite19890404

This comment has been minimized.

Copy link
Contributor

gandalfthewhite19890404 commented Jan 11, 2020

WWE RAW 2 still has issues with announcer voices, also crowd noise does not sounds as should.

@RadWolfie RadWolfie force-pushed the RadWolfie:fix-default-audio-frequency branch from 4db5f24 to a375fab Jan 11, 2020
@RadWolfie

This comment has been minimized.

Copy link
Member Author

RadWolfie commented Jan 11, 2020

Force pushed's diff is a375fab#diff-4859415bafa54277eb749c659b827a8fL1673-R1695

Minimized equation coding to set Xb_Frequency variable directly then set the value to host's.

@RadWolfie

This comment has been minimized.

Copy link
Member Author

RadWolfie commented Jan 11, 2020

@gandalfthewhite19890404, WWE RAW 2 will still have audio issues anyway (not a regression). It will require further investigation. Some of the audio issues may be address in the next pull request.

@literalmente-game

This comment has been minimized.

Copy link
Contributor

literalmente-game commented Jan 11, 2020

MechAssault "jet pack" sound is now correct. Dragon's Lair high pitched tutorial voices are still high pitched

@RadWolfie

This comment has been minimized.

Copy link
Member Author

RadWolfie commented Jan 11, 2020

I had troubleshoot with a tester to figure out the reason Dragon's Lair title's tutorial voices are still high pitched. Since SetFrequency was called first before SetFormat was called. I tried a theory, force original frequency for SetFormat caller, with no confirmation from DirectSound's API doc on msdn. It didn't resolve the issue. At least it is not a regression.

Since there's no regression, ready for merge.

@medievil1

This comment has been minimized.

Copy link

medievil1 commented Jan 12, 2020

wasn't on the list but it fixes the sped up voices of the hobbit (sentences still get cut off however)

@LukeUsher LukeUsher merged commit 2c38dd6 into Cxbx-Reloaded:develop Jan 13, 2020
3 checks passed
3 checks passed
Cxbx-Reloaded.Cxbx-Reloaded Build #20200111.1 succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RadWolfie RadWolfie deleted the RadWolfie:fix-default-audio-frequency branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.