-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CyanEmu Udon emulation does not respect private methods #51
Comments
This is an issue with the vrchat sdk itself and is not something CyanEmu can change without modifying the sdk. |
I see would i be possible to write a SDK edit similar to the one that was made for SDK2 triggers |
Open By default, it will look like this: public override void SendCustomNetworkEvent(NetworkEventTarget target, string eventName)
{
#if UNITY_EDITOR
SendCustomEvent(eventName);
#else
SendCustomNetworkEventHook?.Invoke(this, target, eventName);
#endif
} Change it to look like this: public override void SendCustomNetworkEvent(NetworkEventTarget target, string eventName)
{
SendCustomNetworkEventHook?.Invoke(this, target, eventName);
} |
Updated modifications so it will patch UdonBehavior to respect private methods if in editor mode
Modified modifications.txt to include patch to UdonBehavior to respect private udon methods Fixes CyanLaser#51
Took me a while to find the time to write these changes but here you go :) |
Hey there while debugging i noticed a bug that cyanemu executes methods prefixed with an underscore when they are ran thru sendcustomnetwork event this is in my opinion unwanted behavior the excepted behavior would be for cyanemu to throw an error stating methods prefixed with an underscore cannot be executed over the network.
The text was updated successfully, but these errors were encountered: