Please sign in to comment.
32 bit int shifted by 36 bits at BluetoothMasObexServer.getUint32BigE…
…ndian I have found the bug with the FindBugs tool (http://findbugs.sourceforge.net) The FindBugs description is: 32 bit int shifted by 36 bits at BluetoothMasObexServer.java:[line: 189] 32 bit int shifted by an amount not in the range 0..31 The code performs shift of a 32 bit int by a constant amount outside the range 0..31. The effect of this is to use the lower 5 bits of the integer value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits, and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected, and it is at least confusing. Bug kind and pattern: BSHIFT - ICAST_BAD_SHIFT_AMOUNT Change-Id: I45748b7e980c28a75a4210a8974aa00cd732e1f8
- Loading branch information...
Showing with 6 additions and 4 deletions.