fix: update error logging for missing Qdrant collection and track ign… #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves error handling in the classify_documents_per_collection function by explicitly tracking document slices that fail due to missing Qdrant collections. Previously, these slices were only logged and ignored; now they are also added to the error tracking set.
Key Changes:
- Updated error log message to clarify that failed slices are "flagged as error" rather than "ignored"
- Added failed document IDs to
ret[None]set for proper error tracking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jmsevin
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a minor change to the error handling logic in the
classify_documents_per_collectionfunction. When a collection is not found in Qdrant, the affected document slice is now explicitly flagged as an error in the return value.Error handling improvement:
welearn_datastack/modules/qdrant_handler.py, updated the error message to indicate that the slice is "flagged as error" and added the slice's document ID to theret[None]set to track error cases.…ored slices