Udp fix #7
Merged
Udp fix #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to willcode4, sources and sinks should inherit from gr::block Also, the work() function (or general_work() in this case) is expected to block until the requested number of items are available. This implementation sets an output_multiple so that it is only called when a whole packet can be consumed. For formats that support it, dropped packet detection is implemented by inserted null samples for each missing packet.
For some reason, the "Base" ctor wasn't calling the right gr::block ctor, so it failed miserably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not backwards-compatible. It will break any existing code.
Key aspect of this change is to inherit from
gr::block. Also the work function (nowgeneral_work) was updated based on a better understanding of the GNU Radio scheduler. Finally, removed the virtual inheritance from the interface class; this caused a very subtle bug and adds no practical value.For sources that provide sequence numbers, this change detects dropped packets and inserts null samples to keep the data in alignment. Practically, this should almost never happen, if the kernel is properly tuned with sufficient buffer space. It has been observed near start-up; there may yet be an issue with initialization
I've also observed a reported (tagged) sample rate of 250(!). I don't know where that comes from, but it quickly switches back to a correct sample rate.
I noticed the files I modified don't have a proper copyright statement. You might want to update that?
I added the .clang-format file from GNU Radio, thinking it's reasonable to be consistent with that project. Only my modified files were re-formatted.
I've tested with the NDR-358, and the tags are on the proper packets.