From 0362df1c04ead713fccfced3cbd260861e097e1b Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Mon, 26 Jul 2021 15:14:43 -0300 Subject: [PATCH] fix: New time range filter initially show advance section (#15889) --- .../FiltersConfigForm/FiltersConfigForm.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx index c7300c626e42..a41cb4670dd0 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx @@ -585,6 +585,10 @@ const FiltersConfigForm = ( const defaultToFirstItem = formFilter?.controlValues?.defaultToFirstItem; + const hasAdvancedSection = + formFilter?.filterType === 'filter_select' || + formFilter?.filterType === 'filter_range'; + const preFilterValidator = () => { if (hasTimeRange || hasAdhoc) { return Promise.resolve(); @@ -847,7 +851,7 @@ const FiltersConfigForm = ( .filter(key => BASIC_CONTROL_ITEMS.includes(key)) .map(key => controlItems[key].element)} - {((hasDataset && hasAdditionalFilters) || hasMetrics) && ( + {hasAdvancedSection && (