Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Gradle dependency parsing to catch transitive dependencies #163

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

candrews
Copy link

Previously, transitive dependencies in the Gradle dependencies output like this:

+--- org.postgresql:postgresql -> 42.3.6

would not be caught, amongst other patterns.

Improve dependency parsing by using a regular expression, which also improves readability/maintainability over the previous string indexing based parsing.

Previously, transitive dependencies in the Gradle dependencies output like this:
```
+--- org.postgresql:postgresql -> 42.3.6
```
would not be caught, amongst other patterns.

Improve dependency parsing by using a regular expression, which also
improves readability/maintainability over the previous string indexing
based parsing.
Copy link
Collaborator

@prabhu prabhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you!

@prabhu prabhu merged commit 8e7fec0 into CycloneDX:master Sep 22, 2022
@prabhu
Copy link
Collaborator

prabhu commented Sep 22, 2022

Included in 4.0.36

@prabhu
Copy link
Collaborator

prabhu commented Mar 21, 2023

Hi @candrews, could you help improve the regex to handle the new rich version shown in 271?

#271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants