Skip to content

feat: API endpoint /stats/getViewsByLibraryType#378

Merged
CyferShepard merged 3 commits into
CyferShepard:unstablefrom
Zlendy:get-views-by-library-type
Apr 19, 2025
Merged

feat: API endpoint /stats/getViewsByLibraryType#378
CyferShepard merged 3 commits into
CyferShepard:unstablefrom
Zlendy:get-views-by-library-type

Conversation

@Zlendy

@Zlendy Zlendy commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

Implements #377

@Zlendy

Zlendy commented Apr 19, 2025

Copy link
Copy Markdown
Contributor Author

While I was working on this PR I noticed an issue, fs_watch_stats_popular_days_of_week() (and probably some others too) do not report playbacks on library types other than: Music, Shows and Movies.
I worked around that issue by reporting playbacks from other types as Other.

@Zlendy Zlendy marked this pull request as ready for review April 19, 2025 18:06
@CyferShepard

Copy link
Copy Markdown
Owner

Hey @Zlendy , thanks for the pr. code looks good so im gonna go ahead and merge into unstable

@CyferShepard CyferShepard merged commit 22cd73d into CyferShepard:unstable Apr 19, 2025
@Zlendy

Zlendy commented Apr 19, 2025

Copy link
Copy Markdown
Contributor Author

While I was working on this PR I noticed an issue, fs_watch_stats_popular_days_of_week() (and probably some others too) do not report playbacks on library types other than: Music, Shows and Movies. I worked around that issue by reporting playbacks from other types as Other.

@CyferShepard what about this? were you aware of it or should I convert it into a new issue?

@CyferShepard

Copy link
Copy Markdown
Owner

Hey @Zlendy , sorry i misunderstood that. actually wasn't aware of it. You can log an issue and il get it sorted out

Zlendy added a commit to Zlendy/homepage that referenced this pull request Apr 20, 2025
@Zlendy Zlendy deleted the get-views-by-library-type branch April 21, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants