Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nSLOC is not correct #34

Closed
PatrickAlphaC opened this issue Nov 11, 2023 · 6 comments
Closed

nSLOC is not correct #34

PatrickAlphaC opened this issue Nov 11, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@PatrickAlphaC
Copy link
Member

git clone https://github.com/Cyfrin/6-thunder-loan-audit
cd 6-thunder-loan-audit
make 
aderyn .

You'll see the nSLOC output is incorrect

@alexroan
Copy link
Contributor

Could you be more specific? What is the expected value, and what output do you get?

@alexroan alexroan added the bug Something isn't working label Nov 13, 2023
@PatrickAlphaC
Copy link
Member Author

The output I get is as follows for nSLOC.

# Summary

## Files Summary

| Key | Value |
| --- | --- |
| .sol Files | 8 |
| Total nSLOC | 103 |

However, this is the correct nSLOC values:

Screenshot 2023-11-19 at 9 06 57 PM

@alexroan
Copy link
Contributor

Could you give access to that repo?

@alexroan
Copy link
Contributor

Interesting, the tokei package that we use to get details about the source only reads down to line 23 in src/protocol/ThunderLoan.sol because of this comment syntax:

    /*//////////////////////////////////////////////////////////////
                            STATE VARIABLES
    //////////////////////////////////////////////////////////////*/

it's struggling with /*////////...

@alexroan
Copy link
Contributor

Issue submitted to tokei here

@alexroan
Copy link
Contributor

Fixed by #93 ! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants