Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Terminal Code to AndroidX #856

Merged
merged 5 commits into from May 30, 2019

Conversation

@luongthomas
Copy link
Collaborator

commented May 30, 2019

Describe the pull request

This PR migrates the Terminal code to use AndroidX.

The following imports were updated:

  • navigation-ui-ktx
  • navigation-fragment-ktx
  • support-annotations
  • support-core-ui

Link to relevant issues

luongthomas added 4 commits May 30, 2019
@luongthomas luongthomas requested a review from MatthewTighe May 30, 2019
@luongthomas luongthomas self-assigned this May 30, 2019
@luongthomas

This comment has been minimized.

@@ -188,8 +188,8 @@ dependencies {
implementation "androidx.room:room-runtime:$room_version"
kapt "androidx.room:room-compiler:$room_version"
implementation "androidx.lifecycle:lifecycle-extensions:$lifecycle_version"
implementation "android.arch.navigation:navigation-fragment-ktx:$navigation_version"
implementation "android.arch.navigation:navigation-ui-ktx:$navigation_version"
implementation "androidx.navigation:navigation-fragment-ktx:$navigation_version"

This comment has been minimized.

Copy link
@MatthewTighe

MatthewTighe May 30, 2019

Collaborator

Huh, guess that one was missed by the refactor tool. Nice catch!

Copy link
Collaborator

left a comment

Looks good besides that, thanks for scooping this one up.

@@ -12,5 +12,5 @@
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
org.gradle.parallel=true

android.enableJetifier=true
android.enableJetifier=false

This comment has been minimized.

Copy link
@MatthewTighe

MatthewTighe May 30, 2019

Collaborator

This is false by default if not specified so we can just remove this line.

@codecov-io

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #856 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #856      +/-   ##
============================================
+ Coverage     41.67%   41.83%   +0.15%     
  Complexity      387      387              
============================================
  Files            43       43              
  Lines          3052     3043       -9     
  Branches        483      483              
============================================
+ Hits           1272     1273       +1     
+ Misses         1715     1706       -9     
+ Partials         65       64       -1
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/tech/ula/ServerService.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/tech/ula/utils/NotificationUtility.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
app/src/main/java/tech/ula/utils/AndroidUtility.kt 15.96% <0%> (+0.46%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd9e26...76de0a9. Read the comment docs.

@MatthewTighe MatthewTighe merged commit 207dc2f into master May 30, 2019
4 checks passed
4 checks passed
ci/circleci: build_debug Your tests passed on CircleCI!
Details
ci/circleci: report_coverage Your tests passed on CircleCI!
Details
ci/circleci: test_instrumented Your tests passed on CircleCI!
Details
ci/circleci: test_unit Your tests passed on CircleCI!
Details
@luongthomas luongthomas deleted the termux-androidx branch May 30, 2019
MatthewTighe pushed a commit that referenced this pull request Aug 14, 2019
* Disable jetifier

* Migrate navigation

* Migrate annotations library

* Migrate support core ui

* Remove enableJetifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.