Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifier to beta version names. Fix automated changelogs. #887

merged 6 commits into from Jun 11, 2019


Copy link

commented Jun 11, 2019

I'll manually stop the CD workflow since I intend to make a release with user-facing changes today or tomorrow.

What changes does this PR introduce?

This PR allows beta versions to be assembled such that their version name is -beta-. This should allow us to more easily determine what build users are on when they report issues.

Any background context you want to provide?

Need an easier way to have users report their version than relying on version code.

Where should the reviewer start?


Has this been manually tested? How?

Kind of. I've made sure that

  • The name reflects the version code in the built APK.
  • update_changelogs lane works correctly if files are in the right place.
  • Version information files are generated during build tasks.

The one sticking point will be whether the version information files are correctly persisted across
CI jobs. I think I did it right but I'm wrong about that 90% of the time conservatively.

What value does this provide to our end users?

Better issue reporting and tracking of which beta build they are on.

What GIF best describes this PR or how it makes you feel?

@MatthewTighe MatthewTighe requested a review from luongthomas Jun 11, 2019

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #887   +/-   ##
  Coverage     41.27%   41.27%           
  Complexity      398      398           
  Files            45       45           
  Lines          3191     3191           
  Branches        487      487           
  Hits           1317     1317           
  Misses         1813     1813           
  Partials         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cebfab6...929a529. Read the comment docs.

@MatthewTighe MatthewTighe merged commit 97a6809 into master Jun 11, 2019
4 checks passed
4 checks passed
ci/circleci: build_debug Your tests passed on CircleCI!
ci/circleci: report_coverage Your tests passed on CircleCI!
ci/circleci: test_instrumented Your tests passed on CircleCI!
ci/circleci: test_unit Your tests passed on CircleCI!
@MatthewTighe MatthewTighe deleted the beta-version-name branch Jun 11, 2019
MatthewTighe pushed a commit that referenced this pull request Aug 14, 2019
* Add beta build type to gradle.

* Update signing configs and CD jobs.

* Fix automated changelogs.

* Refine version name and add comment.

* Move versionCode to expected directory for fastlane.

* Treat version name the same as code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.