Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnityEventHandlerAsyncEnumerator cancellation #418

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

adarapata
Copy link
Contributor

refs

The error in the above issue occurred during the next implementation.

_button.OnClickAsAsyncEnumerable()
    .ForEachAsync(_ => print("push")), token)
    .Forget();

This may be due to the fact that the first TOKEN was used to handle the cancellation of the second TOKEN.

I could see it working in my hand, but I need you to see if it's correct. 🙏

@neuecc
Copy link
Member

neuecc commented Nov 1, 2022

Oh...!
Thanks, I'll merge and release soon!

@neuecc neuecc merged commit 710d0d9 into Cysharp:master Nov 1, 2022
@adarapata adarapata deleted the fix-asyncenumerable-cancel branch November 1, 2022 11:40
@neuecc
Copy link
Member

neuecc commented Nov 1, 2022

released at 2.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants