Fix Bug 139 - writes all-zero initialisers in the rodata section

D-Programming-GDC · Jul 12, 2014 · 0fcf8ba · 0fcf8ba
1 parent 28d9830
commit 0fcf8ba
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/gcc/d/ChangeLog b/gcc/d/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-12  Iain Buclaw  <ibuclaw@gdcproject.org>
+
+	* d-objfile.cc(d_finish_symbol): Don't set DECL_INITIAL if the
+	initialiser is all zeros.
+
 2014-07-10  Iain Buclaw  <ibuclaw@gdcproject.org>
 
 	* d-builtins.cc(lookup_ctype_name): Remove function.

diff --git a/gcc/d/d-objfile.cc b/gcc/d/d-objfile.cc
@@ -1807,7 +1807,10 @@ d_finish_symbol (Symbol *sym)
 	      TYPE_NAME (TREE_TYPE (decl)) = get_identifier (sym->Sident);
 	    }
 
-	  DECL_INITIAL (decl) = sinit;
+	  // No gain setting DECL_INITIAL if the initialiser is all zeros.
+	  // Let the backend put the symbol in bss instead, if supported.
+	  if (!initializer_zerop (sinit))
+	    DECL_INITIAL (decl) = sinit;
 	}
       gcc_assert (COMPLETE_TYPE_P (TREE_TYPE (decl)));
     }