This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.gdcproject.org/show_bug.cgi?id=244
The
.d.lo: rule is already responsible for compiling D sources. TheLIBTOOLFLAGS=--tag=Dis only required to make libtool link using gdc. This is useful to record the library dependencies (pthread,...) into the shared libraries. But instead of using the tag which then also applies to the sources we can also just provide a custom link command. We can remove all those custom link commands if we properly configure all dependencies (i.e. pull 240).Note: We have to keep the empty
LIBTOOLFLAGSto avoid these error messages:BTW: The best error message ever: