Skip to content
This repository has been archived by the owner on Jun 20, 2019. It is now read-only.

Do not compile .c and .S files in D mode #249

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

jpf91
Copy link
Contributor

@jpf91 jpf91 commented Oct 6, 2016

Fixes https://bugzilla.gdcproject.org/show_bug.cgi?id=244

The .d.lo: rule is already responsible for compiling D sources. The LIBTOOLFLAGS=--tag=D is only required to make libtool link using gdc. This is useful to record the library dependencies (pthread,...) into the shared libraries. But instead of using the tag which then also applies to the sources we can also just provide a custom link command. We can remove all those custom link commands if we properly configure all dependencies (i.e. pull 240).

Note: We have to keep the empty LIBTOOLFLAGS to avoid these error messages:

src/Makefile.am: object `inflate.$(OBJEXT)' created both with libtool and without

BTW: The best error message ever:

xgcc: error: unrecognized command line option '-nophoboslib'; did you mean '-nophoboslib'?

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jpf91 jpf91 merged commit 796f6a8 into D-Programming-GDC:master Oct 7, 2016
@jpf91 jpf91 deleted the fix244 branch October 7, 2016 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants