This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Use needsCodegen rather than isRoot for determining the static/extern of a template symbol. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a template symbol. This is noticed when building with --enable-default-pie, where calls to extern functions should be marked @plt. When this doesn't happen (and building with -shared-libphobos) the result is bad relocation errors in the linker.
jpf91
approved these changes
Dec 4, 2016
|
I guess I'll have to rebuild the binaries one more time... |
|
@jpf91 - Oops. |
|
Well, we get a release with less bugs this way so that's a good thing ;-) (Last time I forgot to add the follow symlinks flag to 7zip so it included empty text files instead of symlinks in the windows .7z archives... That was a much more annoying reason to rebuild all toolchains) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is noticed when building with --enable-default-pie, where calls to extern functions should be marked
@PLT. When this doesn't happen (and building with -shared-libphobos) the result is bad relocation errors in the linker.See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845377#32