Skip to content
This repository has been archived by the owner on Jun 20, 2019. It is now read-only.

Update setup-gcc.sh to recognize new gcc versions #86

Merged
merged 2 commits into from
Aug 31, 2014
Merged

Update setup-gcc.sh to recognize new gcc versions #86

merged 2 commits into from
Aug 31, 2014

Conversation

timosi
Copy link
Contributor

@timosi timosi commented Aug 31, 2014

No description provided.

@@ -34,10 +34,14 @@ if grep version_string $d_gccsrc/gcc/version.c | grep -q '"3.4'; then
gcc_ver=3.4
elif grep version_string $d_gccsrc/gcc/version.c | grep -q '"4.0'; then
gcc_ver=4.0
elif grep -q -E '^4\.[0-9]+[^0-9]|$' $d_gccsrc/gcc/BASE-VER; then
elif grep -q -E '^4\.[0-9]+[^0-9]' $d_gccsrc/gcc/BASE-VER; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 4.1.x to 4.9.x should be matched with:
elif grep -q -E '^4\.[1-9]([^0-9]|$)' $d_gccsrc/gcc/BASE-VER; then

@ibuclaw
Copy link
Member

ibuclaw commented Aug 31, 2014

Thanks for your contribution!

ibuclaw added a commit that referenced this pull request Aug 31, 2014
Update setup-gcc.sh to recognize new gcc versions
@ibuclaw ibuclaw merged commit 7b6214b into D-Programming-GDC:master Aug 31, 2014
@braddr
Copy link

braddr commented Sep 1, 2014

This change broke the auto-tester build:
https://auto-tester.puremagic.com/test_data.ghtml?projectid=2&runid=72296&logid=12

@timosi
Copy link
Contributor Author

timosi commented Sep 1, 2014

gcc 4.10 is no more recognized and 5.0.0 is required. Has the gcc version in autotester been updated according to the file gcc.version?

@braddr
Copy link

braddr commented Sep 1, 2014

updating now, but that doesn't invalidate the existence of snapshots that were and still are in the 4.10 line.

@timosi
Copy link
Contributor Author

timosi commented Sep 1, 2014

Yes, maybe that was a mistake from both me and Iain. One change will do the trick:
4.[1-9] is changed to 4.[0-9]
4.10 will never be supported, so this does not change anyrhing but the error message may be better. I let Iain decide if he wants to fix this.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 1, 2014

One change will do the trick:
4.[1-9] is changed to 4.[0-9]

Nope, because the patch files were renamed.

Strictly speaking, the only supported snapshot is that found in gcc.version file. I can't guarantee compatibility with any other development snapshot.

Release branches should support all releases from that version, however.

@ibuclaw
Copy link
Member

ibuclaw commented Sep 1, 2014

@braddr - did you manage to get round to adding in that gcc.version check by the way?

@braddr
Copy link

braddr commented Sep 1, 2014

No, but I have about 90% of the code written to enable pulling from multiple projects, meaning that the auto-tester can pull the appropriate branch/tag directly from the GCC github repo rather than having to deal with downloading and using tarballs. The file has been useful though, since I can check it myself to see that things aren't current. Sorry for NOT using it in automation yet.. just keep having other things thrown at me to get done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants