-
Notifications
You must be signed in to change notification settings - Fork 48
Update setup-gcc.sh to recognize new gcc versions #86
Conversation
| @@ -34,10 +34,14 @@ if grep version_string $d_gccsrc/gcc/version.c | grep -q '"3.4'; then | |||
| gcc_ver=3.4 | |||
| elif grep version_string $d_gccsrc/gcc/version.c | grep -q '"4.0'; then | |||
| gcc_ver=4.0 | |||
| elif grep -q -E '^4\.[0-9]+[^0-9]|$' $d_gccsrc/gcc/BASE-VER; then | |||
| elif grep -q -E '^4\.[0-9]+[^0-9]' $d_gccsrc/gcc/BASE-VER; then | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 4.1.x to 4.9.x should be matched with:
elif grep -q -E '^4\.[1-9]([^0-9]|$)' $d_gccsrc/gcc/BASE-VER; then
|
Thanks for your contribution! |
Update setup-gcc.sh to recognize new gcc versions
|
This change broke the auto-tester build: |
|
gcc 4.10 is no more recognized and 5.0.0 is required. Has the gcc version in autotester been updated according to the file gcc.version? |
|
updating now, but that doesn't invalidate the existence of snapshots that were and still are in the 4.10 line. |
|
Yes, maybe that was a mistake from both me and Iain. One change will do the trick: |
Nope, because the patch files were renamed. Strictly speaking, the only supported snapshot is that found in gcc.version file. I can't guarantee compatibility with any other development snapshot. Release branches should support all releases from that version, however. |
|
@braddr - did you manage to get round to adding in that gcc.version check by the way? |
|
No, but I have about 90% of the code written to enable pulling from multiple projects, meaning that the auto-tester can pull the appropriate branch/tag directly from the GCC github repo rather than having to deal with downloading and using tarballs. The file has been useful though, since I can check it myself to see that things aren't current. Sorry for NOT using it in automation yet.. just keep having other things thrown at me to get done. |
No description provided.