This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Implement Exception/Error chaining in unwind EH routines. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs changelog entries |
ibuclaw
force-pushed
the
eh_chaining
branch
2 times, most recently
from
d0cf2ef to
180ab84
Compare
|
Passes the x86_64 testsuite (at least). |
| @@ -573,8 +573,14 @@ class IRVisitor : public Visitor | |||
|
|
|||
| if (vcatch->var) | |||
| { | |||
| tree object = convert_expr(build_exception_object(), | |||
| build_object_type(), vcatch->type); | |||
| // Get return D's internal exception Object. | |||
|
LGTM. |
ibuclaw
added a commit
that referenced
this pull request
Apr 20, 2015
Implement Exception/Error chaining in unwind EH routines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpf91 - This needs a quick review.